Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable iframe-based silent refresh in Code Flow example #34

Closed
jeroenheijmans opened this issue Mar 28, 2020 · 2 comments
Closed

Enable iframe-based silent refresh in Code Flow example #34

jeroenheijmans opened this issue Mar 28, 2020 · 2 comments
Labels
enhancement Request for improvement

Comments

@jeroenheijmans
Copy link
Owner

In #24 we're trying to get Code + PKCE flow working. However, I'm very keen on getting iframe-based silent refresh to work before making Code Flow the new master branch example (as per the newest recommendations).

The reason that iframe-based silent refresh is so important in my opinion, is this scenario:

  1. User lands in your application, logged in on the Identity Server, but not yet in your app
  2. The app fires up, has no refresh token (in fact storage is empty for oauth lib)
  3. The app first tries the iframe based silent refresh, as it should work because the user has a session at the IDS
  4. The silent refresh should work, and the user gets logged in without a prompt

This should've been fixed in manfredsteyer/angular-oauth2-oidc#600 with version 9.1.0, so let's try that and merge it into the #24 branch (and later into the master branch).

@jeroenheijmans jeroenheijmans added the enhancement Request for improvement label Mar 28, 2020
@jeroenheijmans
Copy link
Owner Author

Just logged manfredsteyer/angular-oauth2-oidc#777 because I think it's not working yet.

@jeroenheijmans
Copy link
Owner Author

Workaround added in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for improvement
Projects
None yet
Development

No branches or pull requests

1 participant