Remove deprecated Trainer.slurm_job_id (Lightning-AI#13459)

src/pytorch_lightning/CHANGELOG.md

@@ -278,6 +278,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Removed deprecated `pytorch_lightning.callbacks.lr_monitor.LearningRateMonitor.lr_sch_names` ([#13353](https://github.com/Lightning-AI/lightning/pull/13353))
 
 
+- Removed deprecated `Trainer.slurm_job_id` in favor of `SLURMEnvironment.job_id` ([#13459](https://github.com/PyTorchLightning/pytorch-lightning/pull/13459))
+
+
 - Removed support for the `DDP2Strategy` ([#12705](https://github.com/PyTorchLightning/pytorch-lightning/pull/12705))
 
 

src/pytorch_lightning/trainer/trainer.py

@@ -61,7 +61,6 @@
     PLUGIN_INPUT,
     PrecisionPlugin,
 )
-from pytorch_lightning.plugins.environments.slurm_environment import SLURMEnvironment
 from pytorch_lightning.profilers import (
     AdvancedProfiler,
     PassThroughProfiler,
@@ -2230,11 +2229,6 @@ def use_amp(self) -> bool:
     def is_global_zero(self) -> bool:
         return self.strategy.is_global_zero
 
-    @property
-    def slurm_job_id(self) -> Optional[int]:
-        rank_zero_deprecation("Method `slurm_job_id` is deprecated in v1.6.0 and will be removed in v1.7.0.")
-        return SLURMEnvironment.job_id()
-
     @property
     def distributed_sampler_kwargs(self) -> Optional[dict]:
         if isinstance(self.strategy, ParallelStrategy):

tests/tests_pytorch/deprecated_api/test_remove_1-7.py

@@ -54,12 +54,6 @@ def on_post_move_to_device(self):
         trainer.fit(model)
 
 
-def test_v1_7_0_deprecated_slurm_job_id():
-    trainer = Trainer()
-    with pytest.deprecated_call(match="Method `slurm_job_id` is deprecated in v1.6.0 and will be removed in v1.7.0."):
-        trainer.slurm_job_id
-
-
 def test_v1_7_0_deprecated_max_steps_none(tmpdir):
     with pytest.deprecated_call(match="`max_steps = None` is deprecated in v1.5"):
         _ = Trainer(max_steps=None)