#39 Support for Hazelcast 4.0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
`Hi @jerrinot , since 4.0 is out, can you please check and review this PR? Thanks in advance! :) |
jerrinot
reviewed
Feb 10, 2020
There was a problem hiding this comment.
Thank you for this contribution!
Two comments:
Consider encapsulating the strategy into its own class. DelegatingClassResolver would stay a thin glue between Subzero and Kryo. Now it's both the glue and also a strategy to pick the right method. Maybe it's too much? Not sure. Certainly there are worst parts in the current codebase :))
I don't fancy throwing raw RuntimeException. Maybe IllegalStateE is (slightly) better?
…ception changed to IllegalStateException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes usage of ClassLoaderUtil, which changed package in 4.0.
Closes #39