Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite broken native support in Edge #32

Closed
steadicat opened this issue Aug 31, 2018 · 5 comments
Closed

Overwrite broken native support in Edge #32

steadicat opened this issue Aug 31, 2018 · 5 comments

Comments

@steadicat
Copy link
Contributor

Edge has a partially-broken implementation of URLSearchParams. It does not properly URL-encode values in some cases. For example:

image

As you can see, Edge fails to escape an & if it's preceded by a space, which breaks the whole encoded string.
@steadicat steadicat mentioned this issue Aug 31, 2018
Merged
@jerrybendy
Copy link
Owner

You are right. This bug exists in Edge. Thanks for your PR 😁

jerrybendy added a commit that referenced this issue Sep 5, 2018
@jerrybendy
Fix #32 and release v5.0.0
edb6223
@jerrybendy
Copy link
Owner

I have changed the detection to a closure to make the code looks more clearly. And released version 5.0.0 for a break change.

@erykpiast
Copy link

@jerrybendy what exactly was the breaking change?

@jerrybendy
Copy link
Owner

Ah... Alright... Maybe there is no any breaking change 😂 My mistake

@erykpiast
Copy link

:D That’s good news actually, thank you for the answer!

@jerrybendy jerrybendy mentioned this issue Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steadicat @erykpiast @jerrybendy