Support the scope and variables requests #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
force-pushed
the
variables_pane
branch
4 times, most recently
from
e7fd64e to
4652cf8
Compare
robertsipka
force-pushed
the
variables_pane
branch
2 times, most recently
from
ee558b7 to
8aa80a6
Compare
robertsipka
changed the title
Contributor
Author
|
The Jerryscript PR has just landed. I've removed the WIP flag. |
rtakacs
reviewed
Oct 30, 2018
src/IotjsDebugger.ts
Outdated
| const scopesArray: Array<JerryScopeChain> = await this._protocolhandler.requestScopes(); | ||
| const scopes = new Array<Scope>(); | ||
|
|
||
| for (let scope of scopesArray) { |
There was a problem hiding this comment.
Try to use const for the for loop variable.
rtakacs
reviewed
Oct 30, 2018
src/IotjsDebugger.ts
Outdated
| const id = this._variableHandles.get(args.variablesReference); | ||
| const scopeVariables: Array<JerryScopeVariable> = await this._protocolhandler.requestVariables(Number(id)); | ||
|
|
||
| for (let variable of scopeVariables) { |
Retrieve the list of variables at the current scope and show them under the variables pane. IoT.js-VSCode-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
variables_pane
branch
from
8aa80a6 to
b727469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the list of variables at the current scope and show them under the variables pane.
This will be in WIP status until this Jerryscript PR does not landed.