build: Install headers to system #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daeyeon
reviewed
May 24, 2018
cmake/iotjs.cmake
Outdated
| endif() | ||
|
|
||
| # Install headers | ||
| if("${INCLUDE_INSTALL_DIR}" STREQUAL "") |
Member
There was a problem hiding this comment.
It seems better to put the relevant codes in one place. I suggest moving this code block to the line, 488.
cmake/iotjs.cmake
Outdated
| if("${INCLUDE_INSTALL_DIR}" STREQUAL "") | ||
| set(INCLUDE_INSTALL_DIR "include/iotjs") | ||
| endif() | ||
| install(TARGETS ${TARGET_LIB_IOTJS} DESTINATION ${LIB_INSTALL_DIR}) |
Member
There was a problem hiding this comment.
isn't TARGET_LIB_IOTJS undefined?
daeyeon
reviewed
May 24, 2018
cmake/iotjs.cmake
Outdated
| set(INCLUDE_INSTALL_DIR "include/iotjs") | ||
| endif() | ||
| install(TARGETS ${TARGET_LIB_IOTJS} DESTINATION ${LIB_INSTALL_DIR}) | ||
| file(GLOB IOTJS_HEADERS include/*.js src/*.h) |
Member
There was a problem hiding this comment.
a) include/.js -> include/.h?
b) can you share use cases for headers of src/*.h?
rzr
force-pushed
the
sandbox/rzr/review/install/master
branch
2 times, most recently
from
73c9598 to
54d3c02
Compare
daeyeon
reviewed
May 31, 2018
cmake/iotjs.cmake
Outdated
| ${MBEDTLS_LIBS} | ||
| -Wl,--no-whole-archive | ||
| ${EXTERNAL_LIBS}) | ||
| install(TARGETS ${TARGET_SHARED_IOTJS} DESTINATION ${LIB_INSTALL_DIR}) |
make install will install headers to iotjs headers namespace. This is needed for build developer packages, on debian based system like raspbian for pi0. This change was applied to 1.0 for debian packaging for supporting RPI, and then improved to align to master. Bug: jerryscript-project#1145 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com
rzr
force-pushed
the
sandbox/rzr/review/install/master
branch
from
54d3c02 to
cda7b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make install will install headers to iotjs headers namespace.
This is needed for build developer packages,
on debian based system like raspbian for pi0.
This change was applied to debian packaging for supporting RPI.
Bug: #1145
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com