Update jerry submodule #1737

Yuyupo · 2018-09-04T11:34:15Z

IoT.js-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu

robertsipka · 2018-09-04T11:44:19Z

src/iotjs_string_ext.c

+static const jerry_char_t *magic_string_items[] = {
 #define MAGICSTR_EX_DEF(NAME, STRING) \
-  (const jerry_char_ptr_t) jerry_magic_string_ex_##NAME,
+  (const jerry_char_t *)jerry_magic_string_ex_##NAME,


Space is missing after the closing bracket.

Actually IoT.js style must be applied here (not JerryScript style), so the space is not needed.

robertsipka · 2018-09-04T11:45:48Z

tools/travis_script.py

            if buildtype == 'release':
                set_release_config_tizenrt()
+            # Fixme: EXTRA_LIBPATHS and EXTRA_LIB can be deleted
+            # when TizenRT uses jerry-ext


Use uppercase letters for fixme, and a dot is missing from the end of the sentence.

Thanks, i missed that. Updated the PR accordingly.

robertsipka · 2018-09-04T11:50:06Z

tools/travis_script.py

+                        '--profile=test/profiles/tizenrt.profile',
+                        'EXTRA_LIBPATHS=-L' + DOCKER_IOTJS_PATH +
+                        '/build/arm-tizenrt/' + buildtype + '/lib/',
+                        'EXTRA_LIBS=-ljerry-ext'])


Do you really need to provide the -L / -l option flags in the EXTRA_LIBPATHS and EXTRA_LIBS values?

No need to answer, I see that you need to give it, but I was surprised at first.

hs0225

.

hs0225

LGTM

daeyeon

@Yuyupo Thank you for the contribution!

To All: For debugger, should we take all extensions which could be duplicated with the one in IoT.js? Do we have any alternative? It seems almost harmless but different from the strategy I've understood so far. There was a consensus not to force use of jerry-extension in jerry community so it was separated as the lib. However, debugger seems a different kind.

LaszloLango · 2018-09-05T08:41:44Z

@daeyeon usually the linker deals with the unused functions/features. @Yuyupo, @robertsipka, is this patch cause significant binary gain in any platform? IMHO the main goal of the jerry-ext should be to contain all of the non-standard features, like print builtin or debug server.

zherczeg · 2018-09-05T08:45:13Z

Yes, the design goal of jerry-ext is that the extensions are not depend on each other. So the linker can cut the unused parts. However this would be good to check in practice. I agree to check the binary size change.

robertsipka · 2018-09-05T13:36:18Z

After the libjerry update, the binary sizes with target and test specific profile builds - that contain all the modules that the tests require - are the following:

on STM32F4-Discovery : 247235 bytes.
on ARTIK 053 : 249596 bytes.
on Raspberry Pi 2 : 290130 bytes.

With the latest commit on IoT.js (40ee244) are the following:

on STM32F4-Discovery : 247731 bytes.
on ARTIK 053 : 252125 bytes.
on Raspberry Pi 2 : 292631 bytes.

Conclusion: The binary sizes will be decreased after this patch on these devices.

Updated: I noticed that this patch is not rebased with master. The previous commit is 354f28d on the PR, so there may be a difference in the comparison.
The binary sizes on 354f28d are the following:

on STM32F4-Discovery : 247468 bytes
on ARTIK 053: 253543 bytes
on Raspberry Pi 2 :292952 bytes

zherczeg · 2018-09-06T06:18:18Z

Nice! Thank you for the measurement.

daeyeon · 2018-09-06T09:45:25Z

The size will be more decreased if we can take only debugger from the extensions.

I'm fine that jerry-ext contains all the non-standard features. However, the more non-standard features merged in future will increase the size of jerry-ext, and that will affect the size of IoT.js.

I think that we need to suggest a way in jerryscript to selectively use the features we want. (Currently only debugger)

LaszloLango · 2018-09-06T12:09:49Z

@Yuyupo jerryscript-project/jerryscript#2507 is merged. Could you update the jerry hash?

Yuyupo · 2018-09-07T06:27:23Z

@LaszloLango Updated jerry to the latest.

LaszloLango · 2018-09-07T06:42:00Z

@daeyeon We can open an issue in JerryScript to make the extensions configurable. It would be a good improvement in the engine. It might reduce the compile time too.

daeyeon · 2018-09-07T06:56:41Z

@LaszloLango Thank you for the opinion.

@Yuyupo I can't guess how much this update is urgent. Could you let me know whether waiting for the configuration is fine to you?

LaszloLango · 2018-09-07T09:25:56Z

@daeyeon the update is needed for the VS Code Extension, because of the debugger related changes.

daeyeon

LGTM

LaszloLango

@Yuyupo Please investigate the Travis failures.

IoT.js-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu

LaszloLango

Is the JerryScript hash correct? It looks quite old to me.

Never mind. GitHub tricked me. The JerryScript hash is good. Sorry for the noise.

LaszloLango

LGTM

LaszloLango added the JerryScript label Sep 4, 2018

Yuyupo force-pushed the jerryupdate branch from c789269 to 2da6048 Compare September 4, 2018 11:38

robertsipka reviewed Sep 4, 2018

View reviewed changes

Yuyupo force-pushed the jerryupdate branch from 2da6048 to 46d66f2 Compare September 4, 2018 12:06

hs0225 reviewed Sep 5, 2018

View reviewed changes

hs0225 approved these changes Sep 5, 2018

View reviewed changes

daeyeon requested changes Sep 5, 2018

View reviewed changes

Yuyupo force-pushed the jerryupdate branch from 46d66f2 to 398caea Compare September 7, 2018 06:24

daeyeon approved these changes Sep 7, 2018

View reviewed changes

LaszloLango requested changes Sep 7, 2018

View reviewed changes

Update jerry submodule

adba322

IoT.js-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu

Yuyupo force-pushed the jerryupdate branch from 398caea to adba322 Compare September 7, 2018 09:52

LaszloLango approved these changes Sep 7, 2018

View reviewed changes

LaszloLango previously requested changes Sep 7, 2018

View reviewed changes

LaszloLango approved these changes Sep 7, 2018

View reviewed changes

LaszloLango merged commit 7639ce6 into jerryscript-project:master Sep 7, 2018

rtakacs mentioned this pull request Sep 18, 2018

Disable jerryscript debugger code if not enabled #1749

Closed

Update jerry submodule #1737

Update jerry submodule #1737

Uh oh!

Conversation

Yuyupo commented Sep 4, 2018

Uh oh!

robertsipka Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

LaszloLango Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

robertsipka Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

Yuyupo Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

robertsipka Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

robertsipka Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hs0225 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hs0225 left a comment

Choose a reason for hiding this comment

Uh oh!

daeyeon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LaszloLango commented Sep 5, 2018

Uh oh!

zherczeg commented Sep 5, 2018

Uh oh!

robertsipka commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zherczeg commented Sep 6, 2018

Uh oh!

daeyeon commented Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LaszloLango commented Sep 6, 2018

Uh oh!

Yuyupo commented Sep 7, 2018

Uh oh!

LaszloLango commented Sep 7, 2018

Uh oh!

daeyeon commented Sep 7, 2018

Uh oh!

LaszloLango commented Sep 7, 2018

Uh oh!

daeyeon left a comment

Choose a reason for hiding this comment

Uh oh!

LaszloLango left a comment

Choose a reason for hiding this comment

Uh oh!

LaszloLango left a comment

Choose a reason for hiding this comment

Uh oh!

LaszloLango left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

robertsipka Sep 4, 2018 •

edited

Loading

hs0225 left a comment •

edited

Loading

daeyeon left a comment •

edited

Loading

robertsipka commented Sep 5, 2018 •

edited

Loading

daeyeon commented Sep 6, 2018 •

edited

Loading