build: Fix mistake while testing TARGET_BOARD #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preprocessor can't use == on strings", so new symbols are introduced to test configurations at build time. Note, this mistake was harmless because there weren't any spefic parts among boards, but this will change in upcoming change. Change-Id: I45d87cccc086af05661eaf7b762a4a0274fb2ede Relate-to: rzr/webthing-iotjs#3 Forwarded: jerryscript-project#1892 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
98eca78 to
f6ec4e8
Compare
|
Thanks! LGTM |
galpeter
approved these changes
Jun 19, 2019
haesik
approved these changes
Jun 20, 2019
hs0225
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preprocessor can't use == on strings",
so new symbols are introduced to test configurations
at build time.
Note, this mistake was harmless
because there weren't any spefic parts among boards,
but this will change in upcoming change.
Change-Id: I45d87cccc086af05661eaf7b762a4a0274fb2ede
Relate-to: rzr/webthing-iotjs#3
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com