build: Install headers #1896
Closed
build: Install headers #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you introduce what iotjs-dev is? |
Contributor
Author
|
It's a common pratice to install developers files in a separate package (to save storage), |
Member
|
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 24, 2020
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b Bug: jerryscript-project#1945 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to rzr/iotjs
that referenced
this pull request
Jul 29, 2020
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b Bug: jerryscript-project#1945 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Aug 6, 2020
Reintroduce this feature after 99ec371 It was useful for debian packaging (iotjs-dev), to match quality standards. Email has been updated for community support Relate-to: https://packages.qa.debian.org/i/iotjs.html Fowarded: jerryscript-project#1896 Relate-to: jerryscript-project#1145 Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 15, 2020
Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896). Also remove headers, lib when installing executable. This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 15, 2020
Add extra install step for installing lib along headers (Fixes: jerryscript-project#1896). Also remove headers, lib when installing executable. This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Contributor
Author
|
This change can be ignored if this other change is merged: |
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 15, 2020
installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 15, 2020
installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-15 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 16, 2020
installing the static lib will also install headers (Fixes: jerryscript-project#1896). This is useful for debian's iotjs-dev package The extra archive rule is needed to prevent this error: install TARGETS given no ARCHIVE DESTINATION for static library target Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: jerryscript-project#1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: jerryscript-project#1896 Last-Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
LaszloLango
pushed a commit
that referenced
this pull request
May 12, 2021
Installing the static lib will also install headers (Fixes: #1896). This is useful for debian's iotjs-dev package. The extra archive rule is needed to prevent this error: install TARGETS given no ARCHIVE DESTINATION for static library target Change-Id: Ib9f6cb50631f4cdfeb308108f91ed28e7d204dc4 Forwarded: #1948 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/lib/review/master Bug: #1945 Bug-Debian: https://bugs.debian.org/957364 Relate-to: #1896 Last-Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce this feature after 99ec371
It was useful for debian packaging (iotjs-dev)
Relate-to: #1145
Change-Id: Idd9a18bbe692baeb468152df5149374512e9350b
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com