Fix valgrind memcheck issues #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Member
|
LGTM |
Executed iotjs through valgrind with its own "pass tests". It has reported some memory issues which are fixed in this patch. * Fixed new[] / delete mismatch in iotjs::Environment ParseCommandLineArgument allocates _argv with new[], so ~Environment should deallocate it with delete[]. * Ensured that Buffer.prototype.write did not cause an invalid read in iotjs::BufferWrap::Copy iotjs::___Write_native simply passes its arguments on to iotjs::BufferWrap::Copy, including length. Length is already clamped to the size of the buffer to avoid overflow when writing. However, to ensure that Copy also avoids reading past the end of the string, length must be clamped to the size of the string as well. (All these sanity checks happen at js side.) IoT.js-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run iotjs through valgrind with its own "pass tests". It has reported some memory issues which are fixed in this PR's patches.
Depends on #332