Use 'ECMA_VALUE_CAN_STORE_UINTPTR_VALUE_DIRECTLY' instead of comparis… #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ecma_dealloc_external_pointer (handler_p); | ||
|
|
||
| #endif /* ECMA_VALUE_CAN_STORE_UINTPTR_VALUE_DIRECTLY */ |
Contributor
There was a problem hiding this comment.
/* !ECMA_VALUE_CAN_STORE_UINTPTR_VALUE_DIRECTLY */
Contributor
Author
There was a problem hiding this comment.
Thanks, I've updated this comment.
robertsipka
force-pushed
the
ecma_value_storage
branch
from
6198970 to
e00c373
Compare
| if (sizeof (ecma_external_pointer_t) == sizeof (uint32_t)) | ||
| #ifdef ECMA_VALUE_CAN_STORE_UINTPTR_VALUE_DIRECTLY | ||
|
|
||
| ECMA_PROPERTY_VALUE_PTR (prop_p)->value = (uint32_t) ptr_value; |
Member
There was a problem hiding this comment.
I think ecma_value_t would be a better (future proof) for casting instead of uint32_t.
robertsipka
force-pushed
the
ecma_value_storage
branch
from
e00c373 to
bc17527
Compare
Contributor
Author
|
Thanks for the comments, I've updated this patch. |
|
|
||
| if (sizeof (ecma_external_pointer_t) == sizeof (uint32_t)) | ||
| { | ||
| /* no additional memory was allocated for the pointer storage */ |
Contributor
There was a problem hiding this comment.
I think we should keep this comment
robertsipka
force-pushed
the
ecma_value_storage
branch
from
bc17527 to
80e9fe4
Compare
Contributor
|
LGTM |
| #else /* !ECMA_VALUE_CAN_STORE_UINTPTR_VALUE_DIRECTLY */ | ||
|
|
||
| ecma_external_pointer_t *handler_p = ECMA_GET_NON_NULL_POINTER (ecma_external_pointer_t, | ||
| ECMA_PROPERTY_VALUE_PTR (prop_p)->value); |
Member
There was a problem hiding this comment.
This line is still misaligned.
Contributor
Author
There was a problem hiding this comment.
Fixed, I've overlooked this, thanks.
robertsipka
force-pushed
the
ecma_value_storage
branch
from
80e9fe4 to
4f48cee
Compare
Member
|
LGTM |
…on with 'sizeof' JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
ecma_value_storage
branch
from
4f48cee to
9ee4379
Compare
Contributor
Author
|
rebased with master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on with 'sizeof'
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com