Skip to content

Change current time from uint64_t to double in Date Port API #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akosthekiss merged 1 commit into from
Apr 21, 2016
Merged

Change current time from uint64_t to double in Date Port API #1023

akosthekiss merged 1 commit into from
Apr 21, 2016

Conversation

@akosthekiss
Copy link
Member

@akosthekiss akosthekiss commented Apr 21, 2016

As discussed after #1018

@akosthekiss
Change current time from uint64_t to double in Date Port API
68f3465 
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss akosthekiss added the jerry-port Related to the port API or the default port implementation label Apr 21, 2016
@LaszloLango
Copy link
Contributor

LaszloLango commented Apr 21, 2016

I'm OK with this change. LGTM

@zherczeg
Copy link
Member

zherczeg commented Apr 21, 2016

LGTM. I also preferred double.

@akosthekiss akosthekiss merged commit 68f3465 into jerryscript-project:master Apr 21, 2016
@akosthekiss akosthekiss deleted the port-date-double-time branch April 21, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

jerry-port Related to the port API or the default port implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akosthekiss @LaszloLango @zherczeg