Force enums in snapshots to be 32bits wide #1029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
franc0is
force-pushed
the
force-large-enums
branch
from
4f0ad42 to
d8dbec9
Compare
Member
|
I think it is bad if we directly store enums in the snapshot. I would prefer to change type to uint8_t rather than adding a high value. |
Contributor
Member
|
After #1168 this change becomes invalid. |
Member
|
May I close this PR? |
Member
|
I close this bug. Please feel free to repoen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumptions are hard-coded elsewhere that require these enums to be 32 bits in size, yet it isn't enforced and some compilers will shorten them.
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com