Fix ESP8266 build #1103
Merged
Fix ESP8266 build #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Though this is just a build fix, it fails to run in the target board for some reason that needs investigation. I'll work on this after this PR lands. |
LaszloLango
added
bug
targets/esp8266/source/jerry_run.c
Outdated
| { | ||
| ret_code = jerry_run (); | ||
| jerry_api_value_t res; | ||
| ret_code = jerry_run (&res); |
Contributor
There was a problem hiding this comment.
jerry_api_release_value should be called if jerry_run failes. The parameter of jerry_run is for error value not for result, so the name of the variable is misleading.
seanshpark
force-pushed
the
fixesp8266build
branch
2 times, most recently
from
b355caa to
5771e6e
Compare
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
@seanshpark, please rebase to the current master, so we can land your PR. |
seanshpark
force-pushed
the
fixesp8266build
branch
from
5771e6e to
7c8db7e
Compare
Contributor
Author
|
Done rebase, thank you. |
Contributor
Author
Member
|
We have already spent a lot of time reproducing this issue, but no luck so far. It only appears on travis arm build. I submitted another patch, and it disappeared. |
This change is to fix build for ESP8266 board with jerry_api_value_t changes. JerryScript-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com
seanshpark
force-pushed
the
fixesp8266build
branch
from
7c8db7e to
ed2a360
Compare
Contributor
Author
|
Thank you, rebase and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix build for ESP8266 board with jerry_api_value_t changes.
JerryScript-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com