Skip to content

Move branches into a separate interpreter group. #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zherczeg merged 1 commit into from
Jun 9, 2016
Merged

Move branches into a separate interpreter group. #1127

zherczeg merged 1 commit into from
Jun 9, 2016

Conversation

@zherczeg
Copy link
Member

@zherczeg zherczeg commented Jun 8, 2016

The result processing of branches are removed (breaks are changed to continue) and branch is parsed as GET

Benchmark Perf (sec)
3d-cube.js 1.308 -> 1.272 : +2.822%
3d-raytrace.js 1.538 -> 1.505 : +2.126%
access-binary-trees.js 0.745 -> 0.740 : +0.662%
access-fannkuch.js 3.122 -> 3.048 : +2.376%
access-nbody.js 1.525 -> 1.515 : +0.665%
bitops-3bit-bits-in-byte.js 0.751 -> 0.689 : +8.241%
bitops-bits-in-byte.js 1.048 -> 1.005 : +4.106%
bitops-bitwise-and.js 1.976 -> 1.907 : +3.500%
bitops-nsieve-bits.js 2.474 -> 2.428 : +1.878%
controlflow-recursive.js 0.542 -> 0.526 : +3.077%
crypto-aes.js 1.448 -> 1.400 : +3.351%
crypto-md5.js 0.899 -> 0.886 : +1.397%
crypto-sha1.js 0.849 -> 0.834 : +1.844%
date-format-tofte.js 1.146 -> 1.136 : +0.892%
date-format-xparb.js 0.576 -> 0.578 : -0.296%
math-cordic.js 1.887 -> 1.796 : +4.806%
math-partial-sums.js 1.057 -> 1.042 : +1.405%
math-spectral-norm.js 0.789 -> 0.760 : +3.726%
string-base64.js 4.640 -> 4.650 : -0.234%
string-fasta.js 2.187 -> 2.196 : -0.381%
Geometric mean: +2.319%

@LaszloLango LaszloLango added enhancement An improvement performance Affects performance labels Jun 8, 2016
LaszloLango
LaszloLango reviewed Jun 8, 2016
View reviewed changes
jerry-core/vm/vm.c Outdated
uint16_t literal_index;
READ_LITERAL_INDEX (literal_index);
READ_LITERAL (literal_index,
left_value);
Copy link
Contributor

@LaszloLango LaszloLango Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a short statement. Please write it in one line.

@LaszloLango
Copy link
Contributor

LaszloLango commented Jun 8, 2016

LGTM

@zherczeg
Branch opcodes have no result and either they have a stack argument
d953fbb 
or no arguments at all. To improve the performance, the branch argument
flag is changed into a get argument type which eliminates a flag check
for all executed opcodes. Furthermore branch opcodes skip the put result
phase by changing the "break" to "continue" statements.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@dbatyai
Copy link
Member

dbatyai commented Jun 9, 2016

LGTM

@zherczeg zherczeg merged commit d953fbb into jerryscript-project:master Jun 9, 2016
@zherczeg zherczeg deleted the vm_loop_opt2 branch June 9, 2016 08:45
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement An improvement performance Affects performance

Projects

None yet

Milestone

Engine optimization & enhancement

Development

Successfully merging this pull request may close these issues.

3 participants

@zherczeg @LaszloLango @dbatyai