Fix minor implementation issues found in the JerryScript API. #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please update the API reference too (based on the comment changes). |
LaszloLango
added
enhancement
Contributor
|
LGTM |
docs/02.API-REFERENCE.md
Outdated
| **Summary** | ||
|
|
||
| Parse specified script to execute in Global scope. | ||
| Parse script and construct an ecmascript function. The |
Member
There was a problem hiding this comment.
EcmaScript? (use CamelCase here as well?)
Member
|
LGTM after the doc/comment fixes |
zherczeg
force-pushed
the
api_updates
branch
2 times, most recently
from
5ecfc3c to
3d7f7eb
Compare
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Member
Author
|
Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.