Fix a bug in ArrayBuffer #1479
Merged
Fix a bug in ArrayBuffer #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
requested changes
Dec 9, 2016
| if (arguments_list_len > 0) | ||
| { | ||
| ecma_number_t num = ecma_get_number_from_value (ecma_op_to_number (arguments_list_p[0])); | ||
| ecma_value_t num_value = ecma_op_to_number (arguments_list_p[0]); |
Member
There was a problem hiding this comment.
This can also be a conversion exception.
|
|
||
| try | ||
| { | ||
| var a = new ArrayBuffer(5.5); |
Member
There was a problem hiding this comment.
There should be another case with:
var a = new ArrayBuffer("a string");
Or something non-number.
zherczeg
approved these changes
Dec 9, 2016
Member
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
After the minor style fix, LGTM.
| { | ||
| ecma_number_t num = ecma_get_number_from_value (ecma_op_to_number (arguments_list_p[0])); | ||
| ecma_value_t ret = ecma_make_simple_value (ECMA_SIMPLE_VALUE_EMPTY); | ||
| ECMA_OP_TO_NUMBER_TRY_CATCH (num, arguments_list_p[0], ret); |
Member
There was a problem hiding this comment.
Please put a newline before ECMA_OP_TO_NUMBER_TRY_CATCH.
Member
|
Excellent patch! |
Member
|
I hope you don't mind that I changed the patch description a bit. But please be a bit more verbose in the future. |
* free_value after ecma_op_to_number * add related test file JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang zidong.jiang@intel.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang zidong.jiang@intel.com