Skip to content

Add support of cross-compilation for linux-based targets. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
egavrin merged 2 commits into from
Jun 30, 2015
Merged

Add support of cross-compilation for linux-based targets. #206

egavrin merged 2 commits into from
Jun 30, 2015

Conversation

@egavrin
Copy link
Contributor

@egavrin egavrin commented Jun 18, 2015

Usage:

  • Cross compile:
    make debug.linux TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake
  • Build unittests
    make unittests TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake
  • Run unittests on target board
    ./tools/runners/run-unittests-remote.sh
  • Run JavaScript test on target board
    ./tools/runners/run-tests-remote.sh debug.linux

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com

@egavrin egavrin added enhancement An improvement infrastructure Related to GH Actions or the tested targets development Feature implementation labels Jun 18, 2015
@egavrin egavrin added this to the Core ECMA features milestone Jun 18, 2015
ruben-ayrapetyan
ruben-ayrapetyan reviewed Jun 18, 2015
View reviewed changes
tools/runners/run-javascript-tests.sh Outdated
Copy link

@ruben-ayrapetyan ruben-ayrapetyan Jun 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, it is better to use mktemp utility for generation of a directory with random name.

Copy link
Contributor Author

@egavrin egavrin Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@egavrin egavrin mentioned this pull request Jun 21, 2015
Closed
@egavrin egavrin self-assigned this Jun 21, 2015
@egavrin egavrin force-pushed the origin/cross-dev branch from 4fc8161 to e0f8c72 Compare June 22, 2015 07:42
egavrin
egavrin reviewed Jun 22, 2015
View reviewed changes
jerry-core/parser/js/opcodes-dumper.cpp Outdated
Copy link
Contributor Author

@egavrin egavrin Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to the PR, but required for cross building. I'll push this change as a separate commit.

@egavrin egavrin force-pushed the origin/cross-dev branch 2 times, most recently from e456ab5 to d8a9c3e Compare June 22, 2015 12:35
@egavrin
Copy link
Contributor Author

egavrin commented Jun 22, 2015

@ruben-ayrapetyan gcc version 4.7.4 (Ubuntu/Linaro 4.7.4-2ubuntu1)

@egavrin
Copy link
Contributor Author

egavrin commented Jun 22, 2015

@ruben-ayrapetyan Fix build error using GCC 4.7.4?

@ruben-ayrapetyan
Copy link

ruben-ayrapetyan commented Jun 22, 2015

@egavrin, looks good.

@egavrin egavrin force-pushed the origin/cross-dev branch from d8a9c3e to 74c56b1 Compare June 22, 2015 13:15
@egavrin
Copy link
Contributor Author

egavrin commented Jun 22, 2015

Folks, I've updated the PR, please check.

//cc @galpeter @LaszloLango @ruben-ayrapetyan

@egavrin egavrin assigned galpeter and unassigned egavrin Jun 22, 2015
@egavrin egavrin changed the title Add support for cross compilation for linux-based targets. Add support of cross-compilation for linux-based targets. Jun 22, 2015
@egavrin egavrin force-pushed the origin/cross-dev branch from 74c56b1 to 9b7ece4 Compare June 22, 2015 18:14
ruben-ayrapetyan
ruben-ayrapetyan reviewed Jun 22, 2015
View reviewed changes
tools/precommit-full-testing.sh Outdated
Copy link

@ruben-ayrapetyan ruben-ayrapetyan Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, it is better to wrap variables into quotes, like "$1". In the case, space wouldn't divide variable's value and special characters in path would not be replaced.

http://www.tldp.org/LDP/abs/html/quotingvar.html
"When referencing a variable, it is generally advisable to enclose its name in double quotes. This prevents reinterpretation of all special characters within the quoted string -- except $, ` (backquote), and \ (escape)."

Copy link
Contributor Author

@egavrin egavrin Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it should be wrapped, but other our scripts doesn't follow this style. I may fix it within this PR, but we should fix this in other scripts too.

Copy link
Contributor Author

@egavrin egavrin Jun 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@egavrin egavrin force-pushed the origin/cross-dev branch from 9b7ece4 to b9b1704 Compare June 23, 2015 07:08
@egavrin
Copy link
Contributor Author

egavrin commented Jun 23, 2015

I'll rise a separate pull request to fix other issues in scripts, likewise.

@egavrin
Copy link
Contributor Author

egavrin commented Jun 23, 2015

PR was updated.

@egavrin egavrin force-pushed the origin/cross-dev branch 2 times, most recently from 5ecc00a to 8dc8678 Compare June 23, 2015 10:05
galpeter
galpeter reviewed Jun 26, 2015
View reviewed changes
build/configs/toolchain_linux_x86_64.cmake Outdated
Copy link
Contributor

@galpeter galpeter Jun 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the strip at the end made the x86_64 cross compilation to cause any problems?

Copy link
Contributor Author

@egavrin egavrin Jun 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galpeter no, not really. I may add it back.
I think we can add native toolchain configuration with a separate PR, like Add toolchain_native.cmake.

@egavrin egavrin force-pushed the origin/cross-dev branch from 8dc8678 to 6a1b90e Compare June 29, 2015 17:27
@egavrin
Copy link
Contributor Author

egavrin commented Jun 29, 2015

@galpeter PR was updated, I restored strip.

@egavrin egavrin force-pushed the origin/cross-dev branch 3 times, most recently from f855b19 to 00e00df Compare June 29, 2015 17:48
@egavrin egavrin mentioned this pull request Jun 30, 2015
Merged
galpeter
galpeter reviewed Jun 30, 2015
View reviewed changes
tools/precommit.sh Outdated
Copy link
Contributor

@galpeter galpeter Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this pass the ${TARGETS} as the 2nd, 3rd and etc args? For example if the TARGETS are: debug.linux release.linux. the command will look like this:
./tools/precommit-full-testing.sh ${OUT_DIR} debug.linux release.linux

Maybe we need to enclose the arguments into quotes.

Copy link
Contributor Author

@egavrin egavrin Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@egavrin egavrin force-pushed the origin/cross-dev branch from 00e00df to 6267696 Compare June 30, 2015 11:45
@galpeter
Copy link
Contributor

galpeter commented Jun 30, 2015

seems good to me.

@galpeter galpeter removed their assignment Jun 30, 2015
@egavrin
Copy link
Contributor Author

egavrin commented Jun 30, 2015

Great! Thank you!

egavrin added 2 commits June 30, 2015 15:03
@egavrin
Fix build error using GCC 4.7.4
be2de16 
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com
@egavrin
Add support of cross-compilation for linux-based targets.
444bd32 
Usage:
- Cross compile:
make debug.linux TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake
- Build unittests
make unittests TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake
- Run unittests on target board
./tools/runners/run-unittests-remote.sh <ip> <login> <pass>
- Run JavaScript test on target board
./tools/runners/run-tests-remote.sh debug.linux <ip> <login> <pass>

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin e.gavrin@samsung.com
@egavrin egavrin force-pushed the origin/cross-dev branch from 6267696 to 444bd32 Compare June 30, 2015 12:03
@egavrin egavrin merged commit 444bd32 into master Jun 30, 2015
@egavrin egavrin deleted the origin/cross-dev branch June 30, 2015 12:59
This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

development Feature implementation enhancement An improvement infrastructure Related to GH Actions or the tested targets

Projects

None yet

Milestone

Core ECMA features

Development

Successfully merging this pull request may close these issues.

4 participants

@egavrin @ruben-ayrapetyan @galpeter @LaszloLango