Support static snapshots. #2239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
static_snapshot
branch
2 times, most recently
from
50d3193 to
f6d938a
Compare
zherczeg
force-pushed
the
static_snapshot
branch
2 times, most recently
from
18e5646 to
493f60b
Compare
Unlike normal snapshots, no part of a static snapshot is loaded into the RAM when executed from ROM. Static snapshots rely heavily on external magic strings. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
static_snapshot
branch
from
493f60b to
ea53cd9
Compare
galpeter
reviewed
Mar 19, 2018
| - `is_for_global` - snapshot would be executed as global (true) or eval (false). | ||
| - `is_strict` - strict mode | ||
| - `buffer_p` - buffer to save snapshot to. | ||
| - `buffer_size` - the buffer's size. |
Contributor
There was a problem hiding this comment.
What does the size mean here? Byte size? or element size?
Member
Author
There was a problem hiding this comment.
Byte size just like the other cases (this is mostly a copy-paste). And the plan is rewriting the saving API anyway.
|
|
||
| Unlike normal snaphots static snaphots are fully executed from ROM. Not | ||
| even their header is loaded into the RAM. However they can only depend | ||
| on magic strings and 28 bit integer numbers. Regular expression literals |
Contributor
There was a problem hiding this comment.
I think we should emphasise that the magic strings during the snapshot generation must be the same as the magic strings during execution.
| #endif /* !CONFIG_DISABLE_ES2015_ARROW_FUNCTION */ | ||
|
|
||
| ecma_value_t | ||
| ecma_op_function_has_instance (ecma_object_t *func_obj_p, ecma_value_t value); |
Contributor
There was a problem hiding this comment.
Why do we need to move this function prototype?
Member
Author
There was a problem hiding this comment.
Just to keep the .c side order. Not a critical change though.
Contributor
|
LGTM |
This was referenced Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike normal snapshots, no part of a static snapshot is loaded into the RAM when executed from ROM. Static snapshots rely heavily on external magic strings.