Add finish debugger command. #2240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
requested changes
Mar 12, 2018
| */ | ||
| JERRY_STATIC_ASSERT (JERRY_DEBUGGER_MESSAGES_OUT_MAX_COUNT == 27 | ||
| && JERRY_DEBUGGER_MESSAGES_IN_MAX_COUNT == 18 | ||
| && JERRY_DEBUGGER_MESSAGES_IN_MAX_COUNT == 19 |
Member
There was a problem hiding this comment.
Please increase the ERRY_DEBUGGER_VERSION number.
| JERRY_DEBUGGER_CHECK_PACKET_SIZE (jerry_debugger_receive_type_t); | ||
|
|
||
| JERRY_DEBUGGER_SET_FLAGS (JERRY_DEBUGGER_VM_STOP); | ||
| JERRY_CONTEXT (debugger_stop_context) = JERRY_CONTEXT (vm_top_context_p->prev_context_p); |
Member
There was a problem hiding this comment.
It is worth a comment to describe the NULL case (and why this code is correct).
jerry-debugger/jerry-client-ws.html
Outdated
| " continue|c - continue execution\n" + | ||
| " step|s - step-in execution\n" + | ||
| " next|n - execution until the next breakpoint\n" + | ||
| " finish|f - continue running just after function in the current stack frame returns\n" + |
Member
There was a problem hiding this comment.
comment: continue running until the current function returns
jerry-debugger/jerry-client-ws.py
Outdated
| do_n = do_next | ||
|
|
||
| def do_finish(self, args): | ||
| """ Continue running just after function in the current stack frame returns """ |
| finish | ||
| step | ||
| finish | ||
| continue |
Member
There was a problem hiding this comment.
last one could be a finish as well
Member
Author
|
@zherczeg I've updated the PR based on your requests. |
With this command the engine continue running just after the function in the current stack frame returns. JerryScript-DCO-1.0-Signed-off-by: Imre Kiss kissi.szeged@partner.samsung.com
Contributor
|
For future changes: I think it would have been nicer to not shuffle the existing message enums. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this command the engine continue running just after the function
in the current stack frame returns.
JerryScript-DCO-1.0-Signed-off-by: Imre Kiss kissi.szeged@partner.samsung.com