Skip to content

Fix receiving of byte-code instructions from serializer #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruben-ayrapetyan merged 1 commit into from
Jun 23, 2015
Merged

Fix receiving of byte-code instructions from serializer #227

ruben-ayrapetyan merged 1 commit into from
Jun 23, 2015

Conversation

@ruben-ayrapetyan
Copy link

@ruben-ayrapetyan ruben-ayrapetyan commented Jun 22, 2015

Related issue: #203

@ruben-ayrapetyan ruben-ayrapetyan added bug Undesired behaviour critical Raises security concerns labels Jun 22, 2015
@ruben-ayrapetyan ruben-ayrapetyan added this to the Core ECMA features milestone Jun 22, 2015
@ruben-ayrapetyan ruben-ayrapetyan mentioned this pull request Jun 22, 2015
Closed
@ruben-ayrapetyan ruben-ayrapetyan force-pushed the Ruben-fix-issue-203 branch 2 times, most recently from 7f4ad37 to bc0287c Compare June 22, 2015 15:07
egavrin
egavrin reviewed Jun 22, 2015
View reviewed changes
jerry-core/parser/js/serializer.cpp Outdated
Copy link
Contributor

@egavrin egavrin Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opcode_t *opcodes_p

@egavrin
Copy link
Contributor

egavrin commented Jun 22, 2015

Good to me, after fixing.

@egavrin egavrin assigned galpeter and unassigned egavrin Jun 22, 2015
@ruben-ayrapetyan
Copy link
Author

ruben-ayrapetyan commented Jun 22, 2015

Pull request is updated:

  • alignment of * in serializer_get_opcode parameters list is fixed.

@ruben-ayrapetyan ruben-ayrapetyan added the parser Related to the JavaScript parser label Jun 22, 2015
galpeter
galpeter reviewed Jun 23, 2015
View reviewed changes
jerry-core/vm/pretty-printer.cpp Outdated
Copy link
Contributor

@galpeter galpeter Jun 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect alignment of the *.

@galpeter
Copy link
Contributor

galpeter commented Jun 23, 2015

aside from the minor style issue it looks good to me.

@ruben-ayrapetyan
Copy link
Author

ruben-ayrapetyan commented Jun 23, 2015

Pull request is updated:

  • alignment of * in pp_op_meta parameters list is fixed.

@egavrin
Copy link
Contributor

egavrin commented Jun 23, 2015

make push

Fix receiving of byte-code instructions from serializer.
ab2abfa 
Related issue: #203

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
@ruben-ayrapetyan ruben-ayrapetyan merged commit ab2abfa into master Jun 23, 2015
@ruben-ayrapetyan ruben-ayrapetyan deleted the Ruben-fix-issue-203 branch June 23, 2015 11:06
This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Undesired behaviour critical Raises security concerns parser Related to the JavaScript parser

Projects

None yet

Milestone

Core ECMA features

Development

Successfully merging this pull request may close these issues.

3 participants

@ruben-ayrapetyan @egavrin @galpeter