Skip to content

Conversation

@imiklos
Copy link
Contributor

@imiklos imiklos commented Apr 19, 2018

Rename the function to represent it's real functionality.

JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu

@imiklos imiklos mentioned this pull request Apr 19, 2018
@LaszloLango LaszloLango added the api Related to the public API label Apr 19, 2018
@LaszloLango LaszloLango added this to the Release 2.0 milestone Apr 19, 2018
@imiklos imiklos force-pushed the jerry_value_has_abort_flag branch from c5b1ada to bec6ffa Compare April 26, 2018 13:23
@imiklos
Copy link
Contributor Author

imiklos commented Apr 26, 2018

Also moved the function after the jerry_value_is_undefined, like in the #2290 PR.

@imiklos imiklos force-pushed the jerry_value_has_abort_flag branch from bec6ffa to c5f51e5 Compare April 27, 2018 13:21
@imiklos imiklos force-pushed the jerry_value_has_abort_flag branch 3 times, most recently from aa78ab6 to 8479836 Compare May 3, 2018 08:49
Rename the function to represent it's real functionality.

JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu
@imiklos imiklos force-pushed the jerry_value_has_abort_flag branch from 8479836 to 9274b36 Compare May 3, 2018 09:42
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit 369447a into jerryscript-project:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants