Skip to content

Rename the jerry_get_value_without_error_flag #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imiklos wants to merge 1 commit into from
Closed

Rename the jerry_get_value_without_error_flag #2295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/02.API-REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,7 @@ jerry_value_set_abort_flag (jerry_value_t *value_p);
- [jerry_value_set_error_flag](#jerry_value_set_error_flag)


## jerry_get_value_without_error_flag
## jerry_get_value_without_error

**Summary**

Expand All @@ -1871,7 +1871,7 @@ when it is no longer needed.

```c
jerry_value_t
jerry_get_value_without_error_flag (jerry_value_t value)
jerry_get_value_without_error (jerry_value_t value)
```

- `value` - api value
Expand All @@ -1885,10 +1885,10 @@ jerry_get_value_without_error_flag (jerry_value_t value)

jerry_value_set_error_flag (&value);

jerry_value_t real_value = jerry_get_value_without_error_flag (value);
jerry_value_t real_value = jerry_get_value_without_error (value);
... // process the real_value. Different from `jerry_value_clear_error_flag`,
// the error `value` will not be automatically released after calling
// `jerry_get_value_without_error_flag`.
// `jerry_get_value_without_error`.

jerry_release_value (value);
jerry_release_value (real_value);
Expand Down
4 changes: 2 additions & 2 deletions jerry-core/api/jerry.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,10 +994,10 @@ jerry_value_set_abort_flag (jerry_value_t *value_p)
*
* @return the real value of the jerry_value
*/
jerry_value_t jerry_get_value_without_error_flag (jerry_value_t value) /**< api value */
jerry_value_t jerry_get_value_without_error (jerry_value_t value) /**< api value */
{
return jerry_acquire_value (jerry_get_arg_value (value));
} /* jerry_get_value_without_error_flag */
} /* jerry_get_value_without_error */

/**
* Return the type of the Error object if possible.
Expand Down
2 changes: 1 addition & 1 deletion jerry-core/include/jerryscript-core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ bool jerry_value_has_abort_flag (const jerry_value_t value);
void jerry_value_clear_error_flag (jerry_value_t *value_p);
void jerry_value_set_error_flag (jerry_value_t *value_p);
void jerry_value_set_abort_flag (jerry_value_t *value_p);
jerry_value_t jerry_get_value_without_error_flag (jerry_value_t value);
jerry_value_t jerry_get_value_without_error (jerry_value_t value);

/**
* Error object function(s).
Expand Down
2 changes: 1 addition & 1 deletion targets/nuttx-stm32f4/jerry_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ print_unhandled_exception (jerry_value_t error_value, /**< error value */
{
assert (jerry_value_is_error (error_value));

error_value = jerry_get_value_without_error_flag (error_value);
error_value = jerry_get_value_without_error (error_value);
jerry_value_t err_str_val = jerry_value_to_string (error_value);
jerry_size_t err_str_size = jerry_get_string_size (err_str_val);
jerry_char_t err_str_buf[256];
Expand Down
2 changes: 1 addition & 1 deletion targets/tizenrt-artik053/apps/jerryscript/jerry_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ print_unhandled_exception (jerry_value_t error_value, /**< error value */
{
assert (jerry_value_is_error (error_value));

error_value = jerry_get_value_without_error_flag (error_value);
error_value = jerry_get_value_without_error (error_value);
jerry_value_t err_str_val = jerry_value_to_string (error_value);
jerry_size_t err_str_size = jerry_get_string_size (err_str_val);
jerry_char_t err_str_buf[256];
Expand Down
4 changes: 2 additions & 2 deletions tests/unit-core/test-api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,13 +1049,13 @@ main (void)

TEST_ASSERT (test_api_is_free_callback_was_called);

/* Test: jerry_get_value_without_error_flag */
/* Test: jerry_get_value_without_error */
{
jerry_init (JERRY_INIT_EMPTY);
jerry_value_t num_val = jerry_create_number (123);
jerry_value_set_error_flag (&num_val);
TEST_ASSERT (jerry_value_is_error (num_val));
jerry_value_t num2_val = jerry_get_value_without_error_flag (num_val);
jerry_value_t num2_val = jerry_get_value_without_error (num_val);
TEST_ASSERT (!jerry_value_is_error (num2_val));
double num = jerry_get_number_value (num2_val);
TEST_ASSERT (num == 123);
Expand Down