Add literal property to the byte code list. #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initalizing a property with a constant is frequent in object initializers. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
set_lteral_property
branch
from
5a818a8 to
bc6ef2f
Compare
Member
|
LGTM (informally) |
akosthekiss
reviewed
Jun 19, 2018
Member
akosthekiss
left a comment
akosthekiss
left a comment
There was a problem hiding this comment.
I see the addition in the byte code list and the change in the JS parser. But I don't see changes in the VM. What am I missing?
Member
Author
|
This is a new variant of an existing CBC_SET_PROPERTY opcode and uses the same VM_OC_SET_PROPERTY vm opcode. |
akosthekiss
approved these changes
Jun 20, 2018
Member
akosthekiss
left a comment
akosthekiss
left a comment
There was a problem hiding this comment.
Nice. Thanks for the explanation. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initalizing a property with a constant is frequent in object initializers.