Skip to content

Conversation

@zherczeg
Copy link
Member

@zherczeg zherczeg commented Jun 18, 2018

Currently the byte code start is incorrectly set when a non-strict arguments object is present, and a random memory area is dumped as byte code.

Example:

function abc(a,b) {
  var c = 6;
  return arguments[0] + b + c;
}

The begin is wrong and several CBC_EXT_NOP opcodes are printed at the end.

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango
Copy link
Contributor

It would be great if we could check the opcode dump for each commit on the CI

@akosthekiss
Copy link
Member

Just like with the previous PR, if there is a known misbehaving test case, it would be nice to add it to the regression test suite.

@zherczeg
Copy link
Member Author

Unfortunately in the current environment it is not even remotely possible to test this.

@akosthekiss
Copy link
Member

My only suggestion is to have the test case saved for potential future use (annotated with a descriptive comment). Should we ever get to a state where we can test such issues, the test case wont be lost. And even if this doesn't happen any time soon, the test case should not fail on existing execution tests.

Currently the byte code start is incorrectly set when
a non-strict arguments object is present, and a random
memory area is dumped as byte code.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@zherczeg
Copy link
Member Author

Test case added. Unfortunately we probably forget about this test.

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yichoi yichoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 35ac0e0 into jerryscript-project:master Jun 20, 2018
@zherczeg zherczeg deleted the dump_cbc_fix branch June 21, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants