-
Notifications
You must be signed in to change notification settings - Fork 688
Fix parse_print_final_cbc dump when arguments is used #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LaszloLango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
It would be great if we could check the opcode dump for each commit on the CI |
|
Just like with the previous PR, if there is a known misbehaving test case, it would be nice to add it to the regression test suite. |
|
Unfortunately in the current environment it is not even remotely possible to test this. |
|
My only suggestion is to have the test case saved for potential future use (annotated with a descriptive comment). Should we ever get to a state where we can test such issues, the test case wont be lost. And even if this doesn't happen any time soon, the test case should not fail on existing execution tests. |
Currently the byte code start is incorrectly set when a non-strict arguments object is present, and a random memory area is dumped as byte code. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
|
Test case added. Unfortunately we probably forget about this test. |
akosthekiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yichoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently the byte code start is incorrectly set when a non-strict arguments object is present, and a random memory area is dumped as byte code.
Example:
The begin is wrong and several CBC_EXT_NOP opcodes are printed at the end.