Add %TypedArray%.prototype.fill(value, [ begin [, end ] ]) support. #2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyCalandra
commented
Jun 29, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
| var a = new Int32Array([1, 2, 3, 4, 5]); |
Contributor
Author
There was a problem hiding this comment.
Forgot to add a test for when we take a subarray of an ArrayBuffer -- coming soon.
Done.
JerryScript-DCO-1.0-Signed-off-by: Anthony Calandra anthony@anthony-calandra.com
AnthonyCalandra
force-pushed
the
typedarray-fill-support
branch
from
ebd8838 to
e19d7d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for the
%TypedArray%.prototype.fillfunctionaccording to Section 22.2.3.8 of the ES2015 spec.
JerryScript-DCO-1.0-Signed-off-by: Anthony Calandra anthony@anthony-calandra.com