Rework JerryScript transport layer. #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
debugger_transport
branch
8 times, most recently
from
35cb30a to
0f3f57f
Compare
LaszloLango
requested changes
Jul 12, 2018
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
Nice work, I had just a few comments.
docs/13.DEBUGGER-TRANSPORT.md
Outdated
|
|
||
| **Summary** | ||
|
|
||
| This context represent the current status of processing received data. |
jerry-core/api/jerry-debugger.c
Outdated
|
|
||
| if (jerry_debugger_tcp_create (port)) | ||
| { | ||
| if (!jerry_debugger_ws_create ()) |
Contributor
There was a problem hiding this comment.
Please merge the if statements
docs/13.DEBUGGER-TRANSPORT.md
Outdated
| layers which can encode/decode or send/receive messages transmitted between | ||
| the debugger client and server. | ||
|
|
||
| **Warning** This API is not part of the standard JerryScript API and may change |
Contributor
There was a problem hiding this comment.
IMHO this comment is unnecessary, because this is not part of the public API. Private functions could be changed anytime (and anywhere) in the whole project.
Introducing jerryscript-debugger-transport.h interface, which allows chaining multiple protocols (e.g. tcp and websocket). JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
debugger_transport
branch
from
0f3f57f to
5e26b1e
Compare
Member
Author
|
Thank you for the review. Patch updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing jerryscript-debugger-transport.h interface, which allows chaining multiple protocols (e.g. tcp and websocket).