Update debugger documentation #2471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
documentation
zherczeg
requested changes
Aug 14, 2018
docs/07.DEBUGGER.md
Outdated
| The debugger can be enabled by calling the `jerryx_debugger_after_connect | ||
| (jerryx_debugger_tcp_create (debug_port) && jerryx_debugger_ws_create ())` | ||
| after the `jerry_init ()` function. It initializes the debugger and blocks | ||
| until a client connects. |
Member
There was a problem hiding this comment.
It would be good to emphasize that users can choose from the available transport layer implementations provided by their own environments.
akosthekiss
force-pushed
the
debugger-docs
branch
from
0589790 to
49b9716
Compare
The documentation has not been updated when the HTML client got removed nor when the new transport layer replaced the previous debug server initialization process. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
Member
Author
|
PR updated. I've added some extra words on transport layer customisability. |
akosthekiss
added a commit
to akosthekiss/jerryscript
that referenced
this pull request
Aug 16, 2018
The documentation has not been updated when the HTML client got removed nor when the new transport layer replaced the previous debug server initialization process. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation has not been updated when the HTML client got
removed nor when the new transport layer replaced the previous
debug server initialization process.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu