Change literal status flags to enum. #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
commented
Aug 15, 2018
|
|
||
| /** | ||
| * Maximum number of values pushed onto the stack by a function. | ||
| * Maximum number of values pushed onto the stack by a function. |
Member
Author
There was a problem hiding this comment.
There is a 'C2 A0' character here, which a "NO-BREAK SPACE'. Change it to a normal space.
akosthekiss
requested changes
Aug 15, 2018
jerry-core/parser/js/common.h
Outdated
| */ | ||
| typedef enum | ||
| { | ||
| LEXER_FLAG_VAR = (1 << 0), /** local identifier (var, function arg) */ |
Member
There was a problem hiding this comment.
All the enum value comments need to be /**< as they are after the entity they are documenting.
Member
Author
|
Thank you for the review. Patch updated. |
akosthekiss
reviewed
Aug 15, 2018
jerry-core/parser/js/common.h
Outdated
| LEXER_FLAG_SOURCE_PTR = (1 << 6), /**< the literal is directly referenced in the source code | ||
| * (no need to allocate memory) */ | ||
| LEXER_FLAG_LATE_INIT = (1 << 7), /**< initialize this variable after the byte code is freed */ | ||
| } parser_lexer_literal_status_flags_t; |
Member
There was a problem hiding this comment.
Strange name for this type. It is used in lexer_literal_t, all the enum values have a LEXER_ prefix, yet this type has a parser_ prefix. I'd suggest going for lexer_literal_status_flags_t only.
Member
Author
There was a problem hiding this comment.
Good catch. I haven't noticed that.
Also fix a white space typo. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Contributor
|
LGTM (informal) |
akosthekiss
added
parser
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 20, 2018
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 21, 2018
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 21, 2018
* Revert "jerry: ref to function self should not create new object (#368)" * jerry: change literal status flags to enum Picked from jerryscript-project/jerryscript#2474 * jerry: fix named function expression creation picked from jerryscript-project/jerryscript#2634 * Include test sets
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 24, 2018
* Revert "jerry: ref to function self should not create new object (#368)" * jerry: change literal status flags to enum Picked from jerryscript-project/jerryscript#2474 * jerry: fix named function expression creation picked from jerryscript-project/jerryscript#2634 * Include test sets
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 24, 2018
* Revert "jerry: ref to function self should not create new object (#368)" * jerry: change literal status flags to enum Picked from jerryscript-project/jerryscript#2474 * jerry: fix named function expression creation picked from jerryscript-project/jerryscript#2634 * Include test sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a typo.