Skip to content

Conversation

@akosthekiss
Copy link
Member

The [jerry|ecma]_char_ptr_t types are some old legacy that are
used quite inconsistently. Their [jerry|ecma]_char_t * variants
are used a lot more often, so it's better to stick to one form
throughout the code base.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

The `[jerry|ecma]_char_ptr_t` types are some old legacy that are
used quite inconsistently. Their `[jerry|ecma]_char_t *` variants
are used a lot more often, so it's better to stick to one form
throughout the code base.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss akosthekiss added the api Related to the public API label Aug 28, 2018
@zherczeg zherczeg mentioned this pull request Aug 29, 2018
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango added this to the Release 2.0 milestone Aug 29, 2018
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit a264560 into jerryscript-project:master Aug 30, 2018
@akosthekiss akosthekiss deleted the remove-char_ptr_t branch August 30, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants