Fix object initializer prescanning issues. #2563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
approved these changes
Oct 18, 2018
Member
akosthekiss
left a comment
akosthekiss
left a comment
There was a problem hiding this comment.
LGTM (Although commits should have a little bit more description than a single line of title.)
LaszloLango
approved these changes
Oct 19, 2018
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
I agree with @akosthekiss, please add more detail into the commit message before we land it. The code LGTM.
This patch fixes incorrect syntax errors reported by the prescanner for ES5.1 getter/setter property initializers and ES2015 computed properties. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
prescanner_fixes
branch
from
c86dc0a to
fe48301
Compare
Member
Author
|
Thnak you. More description added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.