Seperate tests from test-api.c - Strings #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
ecma core
zherczeg
requested changes
Oct 19, 2018
Member
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
Good, only a few changes needed.
tests/unit-core/test-api-strings.c
Outdated
| int | ||
| main (void) | ||
| { | ||
|
|
tests/unit-core/test-api-strings.c
Outdated
|
|
||
| static bool | ||
| strict_equals (jerry_value_t a, | ||
| jerry_value_t b) |
Member
There was a problem hiding this comment.
Add description to arguments (I know it is copied, but now we have a stricter style rules).
akosthekiss
requested changes
Oct 26, 2018
tests/unit-core/test-api-strings.c
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "config.h" |
Member
There was a problem hiding this comment.
Is this picking up jerry-core/config.h? As this is an API test and config.h is not part of the public API, it should not be used (or needed).
Member
Author
There was a problem hiding this comment.
The include came from the original test-api.c file, as i initially moved code around, and looks like i forgot to delete it, my bad, will fix it in a moment.
`test-api.c` is containing the testing for all API functions, which resulted in a big and hardly readable file. This PR is the first of many, that tries to segment it into more files, by tested functionality, this time strings and string methods. JerryScript-DCO-1.0-Signed-off-by: Bela Toth tbela@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-api.cis containing the testing for all API functions, which resulted in a big and hardly readable file.This PR is the first of many, that tries to segment it into more files, by tested functionality, this time strings and string methods.
JerryScript-DCO-1.0-Signed-off-by: Bela Toth tbela@inf.u-szeged.hu