Enable test cases #2566
Merged
Enable test cases #2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Oct 24, 2018
tests/jerry/octal.js
Outdated
| assert (18284877335 == 0210167213027); | ||
| assert (18284877335 != 0210167213030); | ||
| assert (18284877335 != 0210167213026); | ||
| assert (typeof 18284877335 == typeof 0210167213027); |
Member
There was a problem hiding this comment.
I would use plain string comparison here ("number")
zherczeg
requested changes
Oct 24, 2018
tests/jerry/octal.js
Outdated
| @@ -12,4 +12,5004 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| assert (010 === 8); | |||
| assert (18284877335 == 0210167213027); | |||
Member
There was a problem hiding this comment.
Use strict equal (===). Same to the tests below.
tests/jerry/octal.js
Outdated
| assert (62582931635 != 0722216740262); | ||
| assert (typeof 62582931635 == typeof 0722216740263); | ||
|
|
||
| assert (-91868027325 == -01 |
Member
There was a problem hiding this comment.
This test is very long. Could we generate these numbers somehow?
tests/jerry/weird-parts.js
Outdated
| @@ -0,0 +1,39 @@ | |||
| // Copyright JS Foundation and other contributors, http://js.foundation | |||
Member
There was a problem hiding this comment.
I don't like the file name. I would call it: special-cases.js
akosthekiss
requested changes
Oct 26, 2018
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| assert (010 === 8); |
Member
There was a problem hiding this comment.
I don't understand this. I don't think that removing a completely valid and passing test file is a good idea (especially in a completely unrelated PR).
Enabled previously disabled test cases in math-pow.js. Everything works as expected. JerryScript-DCO-1.0-Signed-off-by: Csaba Repasi repasics@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled previously disabled test cases in math-pow.js. Everything works as expected.
JerryScript-DCO-1.0-Signed-off-by: Csaba Repasi repasics@inf.u-szeged.hu