Get rid of ? true : false
#2575
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I would like to see the effect on some exotic compiler environments. This has never caused any issues on Linux. |
Member
Author
|
@zherczeg Please, name those exotic compiler environments and also those from whom you expect the feedback. Right now, I see no setup where |
Contributor
Contributor
|
I've tried out JSRemoteTest with this branch on TizenRT target (compiler: arm-none-eabi-gcc - 4.9.3, TizenRT hash:
|
Contributor
|
More detailed output: https://gist.github.com/rtakacs/0de9c0fa1b9a1b4b80162e435dd8f947 An other info: JSRemoteTest uses newer version of TizenRT (Jun 5, 2018) than JerryScript's Travis (Oct 20, 2017). |
akosthekiss
force-pushed
the
no-ternary-true-false
branch
from
2ae2e8a to
6c5d2aa
Compare
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
force-pushed
the
no-ternary-true-false
branch
from
6c5d2aa to
2f85e8f
Compare
Member
Author
|
@rtakacs I've updated the PR. I did not expect |
Contributor
|
@akosthekiss Okay, it works now :) LGTM (informal) |
Member
Author
|
Thanks, @rtakacs |
rtakacs
pushed a commit
to rtakacs/jerryscript
that referenced
this pull request
Nov 27, 2018
The explicit boolean type conversion (introduced by jerryscript-project#2575) desn't work with TizenRT if custom boolean reprezentation is used. Of course, TizenRT gives an opportunity to use the C99 standard boolean (that works well if that is set). I've replaced all the explicit boolean type conversions with double negotions that helps to work JerryScript well with custom boolean types. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
rtakacs
pushed a commit
to rtakacs/jerryscript
that referenced
this pull request
Nov 27, 2018
The explicit boolean type conversion (introduced by jerryscript-project#2575) desn't work with TizenRT if custom boolean representation is used. Of course, TizenRT gives an opportunity to use the C99 standard boolean (that works well if that is set). I've replaced all the explicit boolean type conversions with double negations that helps to work JerryScript well with custom boolean types. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
rtakacs
pushed a commit
to rtakacs/jerryscript
that referenced
this pull request
Nov 27, 2018
The explicit boolean type conversion (introduced by jerryscript-project#2575) desn't work with TizenRT if custom boolean representation is used. Of course, TizenRT gives an opportunity to use the C99 standard boolean (that works well if that is set). I've replaced all the explicit boolean type conversions with double negations that helps to work JerryScript well with custom boolean types. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
rtakacs
pushed a commit
to rtakacs/jerryscript
that referenced
this pull request
Nov 28, 2018
The explicit boolean type conversion (introduced by jerryscript-project#2575) desn't work with TizenRT if custom boolean representation is used. Of course, TizenRT gives an opportunity to use the C99 standard boolean (that works well if that is set). I've replaced all the explicit boolean type conversions with double negations that helps to work JerryScript well with custom boolean types. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
zherczeg
pushed a commit
that referenced
this pull request
Nov 28, 2018
The explicit boolean type conversion (introduced by #2575) desn't work with TizenRT if custom boolean representation is used. Of course, TizenRT gives an opportunity to use the C99 standard boolean (that works well if that is set). I've replaced all the explicit boolean type conversions with double negations that helps to work JerryScript well with custom boolean types. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu