Fix "arguments" and "eval" parsing #2661
Conversation
rerobika
changed the title
rerobika
changed the title
|
Uh bad news. This is a side effect of my other patch which added types for strings. What other effects can it cause. I will be back next week, lets discuss this first please. |
rerobika
force-pushed
the
fix_issue_2656
branch
from
4656ce7 to
a969402
Compare
rerobika
changed the title
|
I've investigated a bit more and you were right, the issues are due to #2634. I think I found an universal solution for it, but it's definitely worth a discussion. |
jerry-core/parser/js/js-lexer.c
Outdated
| context_p->status_flags |= PARSER_ARGUMENTS_NEEDED | PARSER_LEXICAL_ENV_NEEDED; | ||
| context_p->lit_object.literal_p->status_flags |= LEXER_FLAG_NO_REG_STORE; | ||
| context_p->lit_object.type = LEXER_LITERAL_OBJECT_ARGUMENTS; | ||
| if (!(context_p->status_flags & PARSER_ARGUMENTS_NOT_NEEDED)) |
There was a problem hiding this comment.
Perhaps an ident check could work here.
This patch fixes jerryscript-project#2656 and fixes jerryscript-project#2659 as well. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
force-pushed
the
fix_issue_2656
branch
from
a969402 to
0bdfa1a
Compare
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
Please also fix #2699 in this PR.
|
@LaszloLango I've checked whether this PR solves #2699 but unfortunately it isn't since they are not related to each other (only the |
|
@rerobika, it is OK to do it in a new PR if they are not related. |
3 participants
This patch fixes #2656 and fixes #2659 as well.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu