Maintenance of fatal code enum #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ERR_SYSCALL` is a legacy that has not been used anymore since the removal of jerry-libc. This commit removes it from the port API. - `ERR_DISABLED_BYTE_CODE` is a (relatively) recent addition to the fatal code enum. At the time it was added, the documentation has not been updated. This commit adds the missing documentation. (Plus, it removes a superfluous `JERRY_UNREACHABLE` from after a `jerry_fatal (ERR_DISABLED_BYTE_CODE)`.) Note: As the port API is modified, this is an API-breaking change. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
added
enhancement
|
Hi there.. @akosthekiss. I am using jerryscript's snapshot with google's benchmark. I counter this error |
Member
Author
|
@haochenli We are happy to help with errors encountered -- but not here. This is a PR closed 2 years ago, unrelated to the question. If you found a problem, please, open a new issue and give all the requested details (given in the issue template). Then we can discuss things there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERR_SYSCALLis a legacy that has not been used anymore sincethe removal of jerry-libc. This commit removes it from the port
API.
ERR_DISABLED_BYTE_CODEis a (relatively) recent addition to thefatal code enum. At the time it was added, the documentation has
not been updated. This commit adds the missing documentation.
(Plus, it removes a superfluous
JERRY_UNREACHABLEfrom after ajerry_fatal (ERR_DISABLED_BYTE_CODE).)Note: As the port API is modified, this is an API-breaking change.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu