Fix the order of value finalizing in ecma_builtin_typedarray_prototype_join #2726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_join This patch fixes jerryscript-project#2724. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
added
bug
LaszloLango
requested changes
Jan 23, 2019
| } | ||
| ecma_free_value (separator_value); | ||
|
|
||
| ECMA_OP_TO_NUMBER_FINALIZE (length_number); |
Contributor
There was a problem hiding this comment.
Something is messed up here. There should be no return statements between ECMA_OP_TO_NUMBER_TRY_CATCH and ECMA_OP_TO_NUMBER_FINALIZE. IMHO this function needs a serious refactoring.
Member
Author
There was a problem hiding this comment.
Probably it's not the best practice to return between these macros, but in this case all early return statements contains the required ecma_free_values which generally present at the and of the function. I'd also vote for a refactor, but it may worth an other PR, since this PR's aim to fix the reported issue only.
rerobika
added a commit
to rerobika/jerryscript
that referenced
this pull request
Jan 31, 2019
…e_join (jerryscript-project#2726) This patch fixes jerryscript-project#2724. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #2724.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu