Skip to content

Conversation

@rerobika
Copy link
Member

This patch fixes #2733.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

…y_property_names

This patch fixes jerryscript-project#2733.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
}

function fz_collect_values(value) {
if (++recursion_counter >= recursion_limit) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The reason I've slightly modified the original test case is due to the endless recursion call. Via this check the test case can be added, also the fixed area is triggered the same way as in the reported issue.

@rerobika rerobika added bug Undesired behaviour ES2015 Related to ES2015 features labels Jan 28, 2019
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 1ff322b into jerryscript-project:master Jan 31, 2019
@rerobika rerobika deleted the fix_issue_2733 branch February 28, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion 'id < LIT_NON_INTERNAL_MAGIC_STRING__COUNT' failed in lit_get_magic_string_size

3 participants