-
Notifications
You must be signed in to change notification settings - Fork 688
Use custom dispatcher for Array.prototype routines #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom dispatcher for Array.prototype routines #2742
Conversation
|
Performance results:
Most of it is probably noise due to the new code layout.
|
zherczeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor fix.
c1ab183 to
825ca39
Compare
|
Note: #2640 must land first. |
|
@LaszloLango #2640 Adds 4 new Array.prototype routines here, but currently it uses the general dispatcher. If it lands, this patch must be updated with these 4 functions custom dispatcher related bindings. |
|
@rerobika as I see it can be done the other way as well. |
|
Indeed, no matter what PR lands first, the other must be updated as well. |
825ca39 to
cec4788
Compare
|
@LaszloLango I've updated the PR after #2640 has landed. Could you take an other look at it? |
|
@rerobika, are measurement results the same after the rebase? |
|
@LaszloLango Yes they are, these are the new results:
Performance is still unchanged, mostly noise due to the new code layout. |
Binary size gain: - Intel: ~2.5KB (gcc-7.3) - Arm: ~1.2KB (arm-linux-gnueabi-gcc-7.3) JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
cec4788 to
050be98
Compare
LaszloLango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Binary size reduction:
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu