Add missing port functions for Artik053 target #2811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
approved these changes
Apr 2, 2019
Contributor
robertsipka
left a comment
robertsipka
left a comment
There was a problem hiding this comment.
LGTM, works fine with Artik053.
LaszloLango
requested changes
Apr 2, 2019
Yuyupo
force-pushed
the
jerryPortDefaultArtik
branch
from
c54fe93 to
a36f70a
Compare
robertsipka
reviewed
Apr 3, 2019
| { | ||
| free (buffer_p); | ||
| } /* jerry_port_release_source */ | ||
| #endif |
Contributor
There was a problem hiding this comment.
Missing comment after #endif
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu
Yuyupo
force-pushed
the
jerryPortDefaultArtik
branch
from
a36f70a to
707eb80
Compare
Contributor
Author
|
@LaszloLango @robertsipka Thanks for your comments i've updated it accordingly. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu