Skip to content

Conversation

@ossy-szeged
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu

@ossy-szeged ossy-szeged force-pushed the fix-unittests-win branch 2 times, most recently from 35c81f4 to 88acac8 Compare August 27, 2019 16:00
@ossy-szeged ossy-szeged changed the title [WIP] Make run-tests --unittests work on Windows too Make run-tests --unittests work on Windows too Aug 27, 2019
ossy-szeged added a commit to ossy-szeged/jerryscript that referenced this pull request Aug 27, 2019
Changes:
* Disable failing tests
* Execute tools/run-tests.py --buildoption-tests on AppVeyor
* note: it depends on jerryscript-project#3026

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
@ossy-szeged ossy-szeged force-pushed the fix-unittests-win branch 2 times, most recently from e8bdf5f to 3c82c0d Compare August 29, 2019 08:59
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Changes:
* Bash based unittest runner replaced with a python runner
* Typo fixed in doctest cmake build system (python executable)
* run-tests.py prints error message if build fails

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika merged commit 3ba6adc into jerryscript-project:master Sep 2, 2019
@ossy-szeged ossy-szeged deleted the fix-unittests-win branch September 4, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants