Skip to content

Conversation

@galpeter
Copy link
Contributor

@galpeter galpeter commented Sep 4, 2019

In the jerry-ext there is a native 'assert' handler implemented.
This change adds extra backtrace information if an 'assert' call fails.

To print out the backtrace the library should be built with JERRY_LINE_INFO enabled.

@galpeter galpeter added test Related to testing jerry-ext Related to the jerry-ext library labels Sep 4, 2019
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the jerry-ext there is a native 'assert' handler implemented.
This change adds extra backtrace information if an 'assert' call fails.

To print out the backtrace the library should be built with `JERRY_LINE_INFO` enabled.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 57f389d into jerryscript-project:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jerry-ext Related to the jerry-ext library test Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants