Skip to content

Conversation

@ossy-szeged
Copy link
Contributor

This test is based on pthread, and there is no pthread on Windows.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu

@ossy-szeged ossy-szeged changed the title Disable jerry_create_context doctest on Windows Disable unsupported doctest tests on Windows Sep 19, 2019
@ossy-szeged ossy-szeged changed the title Disable unsupported doctest tests on Windows [WIP]Disable unsupported doctest tests on Windows Sep 19, 2019
Disable 02.API-REFERENCE-create-context.c, because
it is based on pthread, and there is no pthread on Windows.

Disable 11.EXT-REFERENCE-AUTORELEASE.c and test-ext-autorelease.c
if compiler is MSVC, because MSVC doesn't support cleanup attribute.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
@ossy-szeged ossy-szeged changed the title [WIP]Disable unsupported doctest tests on Windows Disable unsupported doctest tests on Windows Sep 19, 2019
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 1acbf83 into jerryscript-project:master Sep 20, 2019
@ossy-szeged ossy-szeged deleted the fix-doctest-win branch September 20, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants