Skip to content

Conversation

@dbatyai
Copy link
Member

@dbatyai dbatyai commented Oct 1, 2019

This flag provides no benefit, and removing it makes debugging easier. Abort is now always called when an assert fails.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
@dbatyai dbatyai added the infrastructure Related to GH Actions or the tested targets label Oct 1, 2019
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit 2180d97 into jerryscript-project:master Oct 3, 2019
@dbatyai dbatyai deleted the remove_abort_on_fail branch November 28, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Related to GH Actions or the tested targets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants