Update API version to 2.1.0. #3220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
reviewed
Oct 16, 2019
Member
akosthekiss
left a comment
akosthekiss
left a comment
There was a problem hiding this comment.
Minor comment: IMHO "Closes #3104" would look better in the commit message, as the referenced issue is not a bug to be fixed.
ossy-szeged
force-pushed
the
update-api-version
branch
from
f08146c to
d42cff2
Compare
Contributor
Author
Good point, I fixed the commit message. |
Closes jerryscript-project#3104. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
ossy-szeged
force-pushed
the
update-api-version
branch
from
d42cff2 to
e35abc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3104.
JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu