Update the Array.prototype.reverse method to support ES6 version #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
reviewed
Apr 15, 2020
szilagyiadam
force-pushed
the
array_reverse_es6
branch
from
24ff3c2 to
d2f3fdf
Compare
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
szilagyiadam
force-pushed
the
array_reverse_es6
branch
from
d2f3fdf to
b79b319
Compare
galpeter
reviewed
Apr 22, 2020
|
|
||
| if (ECMA_IS_VALUE_ERROR (lower_value)) | ||
| { | ||
| goto clean_up; |
Contributor
There was a problem hiding this comment.
In these error cases, should we return the error for the user? Do we have test cases for these?
Contributor
Author
There was a problem hiding this comment.
These test cases have already been tested in the ES5 tests, this update just changes the order of methods, but the behaviour when one of these error occurs is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu