Implement proper creation of function arguments, let and const declarations. #3725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
arguments_ref
branch
4 times, most recently
from
e9a68ba to
2f99a0c
Compare
zherczeg
changed the title
zherczeg
force-pushed
the
arguments_ref
branch
5 times, most recently
from
d16e570 to
45554ff
Compare
rerobika
approved these changes
May 12, 2020
Member
rerobika
left a comment
rerobika
left a comment
There was a problem hiding this comment.
LGTM, after these minor changes
Member
Author
|
Thank you for the review. Patch updated, please check. |
…ations. After the rework it is possible to detect use before init errors for function arguments. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the rework it is possible to detect use before init errors.