Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in SerializeJSONProperty #3816

Merged
merged 1 commit into from
May 30, 2020
Merged

Fix error handling in SerializeJSONProperty #3816

merged 1 commit into from
May 30, 2020

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented May 30, 2020

Fixes #3813.

@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels May 30, 2020
@dbatyai
Fix error handling in SerializeJSONProperty
0ef06f0 
Fixes jerryscript-project#3813.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
zherczeg
zherczeg approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rerobika
rerobika approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit d06c3a7 into jerryscript-project:master May 30, 2020
@dbatyai dbatyai deleted the json_serialize_symbol branch June 10, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerobika rerobika rerobika approved these changes

@zherczeg zherczeg zherczeg approved these changes

Assignees
No one assigned
Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
No milestone
3 participants
@dbatyai @zherczeg @rerobika