Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypedArray initialization with another TypedArray #3850

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

szilagyiadam
Copy link
Contributor

Fixes #3836

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

@szilagyiadam szilagyiadam changed the title Fix the TypedArray initialization where the internal buffer is a TypedArray Fix TypedArray initialization with another TypedArray Jun 4, 2020
@szilagyiadam szilagyiadam force-pushed the fix_3836 branch 2 times, most recently from 00ce4e4 to 7b095c9 Compare June 4, 2020 11:43
@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Jun 4, 2020
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a minor fix

jerry-core/ecma/operations/ecma-typedarray-object.c Outdated Show resolved Hide resolved
Fixes jerryscript-project#3836

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit 90fd881 into jerryscript-project:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
5 participants