-
Notifications
You must be signed in to change notification settings - Fork 683
Fixes nuttx target warning #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes nuttx target warning #4984
Conversation
Good catch! I think, it's better to remove that parameter since |
LGTM (informal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it would be great to have a formal commit message, we don"t put complete build logs to the commit messages.
The warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
969b681
to
6358606
Compare
Closed by accident, @ossy-szeged updated and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requested change has been done
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com